Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

robust_access_vertex shader add float tolerance #3968

Merged
merged 2 commits into from
Sep 25, 2024

Conversation

shrekshao
Copy link
Contributor

@shrekshao shrekshao commented Sep 25, 2024

Issue: https://crbug.com/365974434

Bump up floating point number comparison with some tolerance. (As GLES highp float are subset of IEEE 754 32bit float)

This fix decrease local failing tests on Android pixel 6 chrome from 128 -> 93 74. I think newly passes ones are mostly control case flakes.

Still need to look into actual ooo failures.


Requirements for PR author:

  • All missing test coverage is tracked with "TODO" or .unimplemented().
  • New helpers are /** documented */ and new helper files are found in helper_index.txt.
  • Test behaves as expected in a WebGPU implementation. (If not passing, explain above.) (Still Failing compat android pixel 6 but fewer)
  • Test have be tested with compatibility mode validation enabled and behave as expected. (If not passing, explain above.)

Requirements for reviewer sign-off:

  • Tests are properly located in the test tree.
  • Test descriptions allow a reader to "read only the test plans and evaluate coverage completeness", and accurately reflect the test code.
  • Tests provide complete coverage (including validation control cases). Missing coverage MUST be covered by TODOs.
  • Helpers and types promote readability and maintainability.

When landing this PR, be sure to make any necessary issue status updates.

Copy link
Contributor

@greggman greggman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm with a couple of questions

@shrekshao shrekshao merged commit 11ac59b into gpuweb:main Sep 25, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants