Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable automated security updates on both v1.x and main branches #79

Open
nitrocode opened this issue Jan 4, 2024 · 5 comments
Open

Comments

@nitrocode
Copy link

nitrocode commented Jan 4, 2024

It would be nice to enable dependabot / renovatebot in this repo so PRs to bump vulnerable dependencies can be opened sooner.

@gr2m
Copy link
Owner

gr2m commented Jan 10, 2024

We use @renovatebot, it sends updates for security updates, too, and I think it can be configured to update maintenance branches as well, but I'm not sure

@nitrocode
Copy link
Author

Oh I didn't realize. I didn't see a renovate.json* file in this repo.

I see some of the repos in this org that do have it configured.

https://github.com/gr2m/ts-jest/blob/main/renovate.json

Does this repo have renovatebot enabled?


Yes, it does look like baseBranches can be configured in renovate to target multiple branches

{
  "baseBranches": ["main", "v1.x"]
}

@nitrocode nitrocode changed the title Enable dependabot on v1.x and main branches Enable automated security updates on both v1.x and main branches Jan 15, 2024
@gr2m
Copy link
Owner

gr2m commented Jan 15, 2024

My fault, it was not yet enabled, I did enable it now for main:
#81

Can you backport this to 1.x?

@nitrocode
Copy link
Author

Not a problem at all. Thanks for enabling it.

Did you mean to backport the same change you made or also add the baseBranches key?

I've never updated the package.json with the renovate config. I didn't know that worked. I've always updated the renovate.json* file to configure the bot.

@gr2m
Copy link
Owner

gr2m commented Jan 16, 2024

I never worked with baseBranches but I assume that configuration needs to go into the main branch. The value can include a regex so it should cover all future [number].x branches: https://docs.renovatebot.com/configuration-options/#basebranches

I didn't have renovate enabled on maintenance branches before, but I assume it needs a renovation configuration in the respective branch as well, so I think backporting the change of my PR to 1.x makes sense

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants