Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why agent requires adm group on deb package? #7005

Open
gcb opened this issue Aug 21, 2024 · 2 comments
Open

Why agent requires adm group on deb package? #7005

gcb opened this issue Aug 21, 2024 · 2 comments
Labels
bug Something isn't working needs-attention An issue or PR has been sitting around and needs attention.

Comments

@gcb
Copy link

gcb commented Aug 21, 2024

What's wrong?

seeing #524
and the fix #737

files moved around, new location at https://github.com/rfratto/agent/blob/main/packaging/grafana-agent/deb/control/postinst#L23 still without explanation

instead of simply adding the user to the journald reader permission group systemd-journal, it is also added to adm group with no further explanation why.

adm is usually not required to read logs and can act on a lot more in regular setups.

Steps to reproduce

  1. install
  2. remove user from group
  3. nothing bad happens as far as i can tell.

System information

No response

Software version

No response

Configuration

No response

Logs

No response

@gcb gcb added the bug Something isn't working label Aug 21, 2024
Copy link
Contributor

This issue has not had any activity in the past 30 days, so the needs-attention label has been added to it.
If the opened issue is a bug, check to see if a newer release fixed your issue. If it is no longer relevant, please feel free to close this issue.
The needs-attention label signals to maintainers that something has fallen through the cracks. No action is needed by you; your issue will be kept open and you do not have to respond to this comment. The label will be removed the next time this job runs if there is new activity.
Thank you for your contributions!

@github-actions github-actions bot added the needs-attention An issue or PR has been sitting around and needs attention. label Sep 25, 2024
@gcb
Copy link
Author

gcb commented Sep 27, 2024

any functionality is impacted that I am missing?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working needs-attention An issue or PR has been sitting around and needs attention.
Projects
None yet
Development

No branches or pull requests

1 participant