Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use unique handle for discovery and generic targets to save GC and memory #1999

Open
mattdurham opened this issue Oct 29, 2024 · 0 comments
Open
Labels
enhancement New feature or request

Comments

@mattdurham
Copy link
Collaborator

mattdurham commented Oct 29, 2024

Request

Targets/Discovery are represented as list(map[string]), with discovery running every 5 seconds in very large clusters the garbage collector can spike due to creating these labels. The names especially are repeated. The hard part is implementing the capsule value so hard coded targets still work. This is because in the alloy runtime there is a bug where you cannot convert from list/map to a capsule value.

In reviewing profiles this code was by far the largest allocator.

allTargets := []Target{}

Use case

Reduce memory and cpu

@mattdurham mattdurham added the enhancement New feature or request label Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant