Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce GetCommits for batch resolving commits #154

Open
marcsanmi opened this issue Sep 6, 2024 · 0 comments
Open

Introduce GetCommits for batch resolving commits #154

marcsanmi opened this issue Sep 6, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@marcsanmi
Copy link

Context

The current GetCommit API resolves a single commit at a time using the GitHub API. This means that if a profile contains N different versions, the frontend must make N separate requests to retrieve information about each commit. This creates significant network overhead, which could be avoided if the GetCommit API could accept a list of commit references and resolve them all in parallel before responding to the frontend.

The backend has already been updated to support resolving multiple commits at once (see: grafana/pyroscope#3529) by introducing a new GetCommits endpoint.

Action Required

The fronted needs to be updated to leverage this new capability.

@marcsanmi marcsanmi added the enhancement New feature or request label Sep 6, 2024
@ifrost ifrost assigned ifrost and unassigned ifrost Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants