You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The current k6 Homebrew formula doesn't set any of the build flags we use in build-release.sh like -trimpath or -ldflags to inject the build date and Git commit, so the k6 version output for the Homebrew binary is e.g. k6 v0.31.1 ((devel), go1.16.2, darwin/amd64). This should be consistent with how build-release.sh works, which generates a version string like k6 v0.31.1 (2021-03-17T13:23:23+0000/e9d8349, go1.15.8, linux/amd64), while also keeping in mind #1996.
The text was updated successfully, but these errors were encountered:
After an internal discussion with the team, we've decided to close this issue as it's no longer such a problem as it was exposed at the initial description of the issue, where the build seemed to be a development one.
Also considering that:
The k6 version (e.g. v0.50.0, without the commit hash) should be enough in the vast majority of cases when debugging bugs or doing things like that.
The way k6 is being built now for Homebrew: running go build over the release source code, instead of, for instance, pulling the binaries from GH releases, seems to be the convention in Homebrew.
So, with that being said, we've decided to close this for now. If anybody finds this issue, and have any meaningful argument in favor of putting some efforts to make k6 version outputs look the same, please share. Likewise, if we ever re-consider this more important, we may want to explore a solution. For now, it just doesn't deserves the effort.
The current k6 Homebrew formula doesn't set any of the build flags we use in
build-release.sh
like-trimpath
or-ldflags
to inject the build date and Git commit, so thek6 version
output for the Homebrew binary is e.g.k6 v0.31.1 ((devel), go1.16.2, darwin/amd64)
. This should be consistent with howbuild-release.sh
works, which generates a version string likek6 v0.31.1 (2021-03-17T13:23:23+0000/e9d8349, go1.15.8, linux/amd64)
, while also keeping in mind #1996.The text was updated successfully, but these errors were encountered: