Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Helm: sidecar is not part of singleBinary #10967

Closed
awoimbee opened this issue Oct 19, 2023 · 2 comments · Fixed by #13572
Closed

Helm: sidecar is not part of singleBinary #10967

awoimbee opened this issue Oct 19, 2023 · 2 comments · Fixed by #13572
Labels
area/helm type/bug Somehing is not working as expected

Comments

@awoimbee
Copy link

awoimbee commented Oct 19, 2023

Describe the bug
When I deploy loki in singleBinary mode, but sidecar.rules.enabled is true, I expect the sidecar to be deployed with loki.
But it's not, a code search (repo:grafana/loki path:/^production\/helm\/loki\/templates\// sidecar) shows that sidecar is only present in statefulset-backend.yaml.

What I did:
Switched to the "scalable" deployment, got better query speeds at the same time !

@JStickler JStickler added area/helm type/bug Somehing is not working as expected labels Oct 23, 2023
@marknesterovych
Copy link

Got the same situation. sidecar is ignored in single binary mode.

@alarobric
Copy link

Is there any reason for this to be the case? I'm finding documentation on how to actually deploy recording rules or alerts to be quite sparse, and now finding that the helm chart support for this isn't there either.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/helm type/bug Somehing is not working as expected
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants