-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Detected labels from store #12441
Conversation
28f3c4e
to
3d0249f
Compare
3d0249f
to
30329f7
Compare
Note: This PR has #12505 already merged within. The diff will get smaller after the tests PR is merged first. |
@trevorwhitney fixed all PR comments. Can you take a look again, thank you! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
changes look good, thanks @shantanualsi! one question left about the slice.Contains
vs using a map
, wasn't sure where we landed with that? I'm fine if we want to keep it for now since it's such a small value, but something we should keep in mind if we plan to grow that in the future or allow each tenant to configure their own.
What this PR does / why we need it:
Which issue(s) this PR fixes:
Re: #12341
Special notes for your reviewer:
Checklist
CONTRIBUTING.md
guide (required)CHANGELOG.md
updatedadd-to-release-notes
labeldocs/sources/setup/upgrade/_index.md
production/helm/loki/Chart.yaml
and updateproduction/helm/loki/CHANGELOG.md
andproduction/helm/loki/README.md
. Example PRdeprecated-config.yaml
anddeleted-config.yaml
files respectively in thetools/deprecated-config-checker
directory. Example PR