Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(mixins): add backend path section in loki-operational for single scalable deployment #13023

Merged
merged 4 commits into from
Sep 18, 2024
Merged

fix(mixins): add backend path section in loki-operational for single scalable deployment #13023

merged 4 commits into from
Sep 18, 2024

Conversation

QuentinBisson
Copy link
Contributor

@QuentinBisson QuentinBisson commented May 23, 2024 •
edited
Loading

What this PR does / why we need it:

This PR adds a backend path row in loki operational just after the read path

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
    • Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such, feat PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • For Helm chart changes bump the Helm chart version in production/helm/loki/Chart.yaml and update production/helm/loki/CHANGELOG.md and production/helm/loki/README.md. Example PR
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR

@QuentinBisson QuentinBisson requested a review from a team as a code owner May 23, 2024 12:53
@QuentinBisson QuentinBisson force-pushed the add-mixin-for-backend-resources branch from f6dd4be to 753feb2 Compare May 23, 2024 12:53
@QuentinBisson QuentinBisson force-pushed the add-mixin-for-backend-resources branch from 753feb2 to 8d423d1 Compare May 23, 2024 12:55
@cstyan
Copy link
Contributor

cstyan commented Jun 3, 2024

sorry for the delay @QuentinBisson, I was away last week, can review this week

@QuentinBisson
Copy link
Contributor Author

@cstyan don't worry about it, I was busy fixing Mimir mixins 😅

Now regarding this one, i was wondering if it would not be better to have a single single scalable resource dashboard instead of having 1 for read, 1 for write and 1 for backend that all contain only 1 row anyway. What do you think?

@cstyan
Copy link
Contributor

cstyan commented Jun 4, 2024

@cstyan don't worry about it, I was busy fixing Mimir mixins 😅

Now regarding this one, i was wondering if it would not be better to have a single single scalable resource dashboard instead of having 1 for read, 1 for write and 1 for backend that all contain only 1 row anyway. What do you think?

that seems like a good idea to me 👍

@QuentinBisson QuentinBisson mentioned this pull request Jul 10, 2024
Merged
7 tasks
@QuentinBisson
Copy link
Contributor Author

PR is here #13471

@QuentinBisson QuentinBisson force-pushed the add-mixin-for-backend-resources branch from 75b3a74 to b30e69d Compare July 24, 2024 13:22
@QuentinBisson QuentinBisson changed the title fix(mixins): add backend resource mixin for single scalable deployment fix(mixins): add backend path section in loki-operational for single scalable deployment Jul 24, 2024
@QuentinBisson
Copy link
Contributor Author

@cstyan I renamed the PR to match what it really does as the Merge PR for resources is here #13471

@QuentinBisson
Copy link
Contributor Author

@cstyan would you be able to review my PRs?

@cstyan
Copy link
Contributor

cstyan commented Sep 17, 2024

@QuentinBisson again, need to merge in main after the other PRs were merged

cstyan
cstyan reviewed Sep 18, 2024
View reviewed changes
production/loki-mixin/dashboards.libsonnet
@@ -4,9 +4,9 @@
(import 'dashboards/loki-logs.libsonnet') +
(import 'dashboards/loki-operational.libsonnet') +
(import 'dashboards/loki-reads.libsonnet') +
(import 'dashboards/loki-reads-resources.libsonnet') +
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did you mean to change this, or was it a linter change?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did, I thought having both read dashboards close to each other made sense but I can revert this one of you prefer

@cstyan cstyan merged commit 16881ab into grafana:main Sep 18, 2024
61 checks passed
@loki-gh-app loki-gh-app bot mentioned this pull request Sep 23, 2024
Open
@loki-gh-app loki-gh-app bot mentioned this pull request Sep 30, 2024
Open
@loki-gh-app loki-gh-app bot mentioned this pull request Oct 7, 2024
Open
This was referenced Oct 14, 2024
Open
Closed
This was referenced Oct 21, 2024
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cstyan cstyan cstyan approved these changes

Assignees
No one assigned
Labels
size/XL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@QuentinBisson @cstyan