-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Added video #13032
feat: Added video #13032
Conversation
This PR must be merged before a backport PR will be created. |
1 similar comment
This PR must be merged before a backport PR will be created. |
@Jayclifford345 could you edit this PR so that it is just adding the video? I've already got a WIP PR for the Alloy changes (and we do not want to delete the Agent references, as the Agent is still supported). |
This reverts commit ef59bbf.
Hey @JStickler! Absolutely, sorry I had put in the request before our conversation on Slack. I reverted my change and just added the video. Let me know if this has changed correctly. |
I also got a weird test fail I haven't seem before: ✖ pkg/ruler/base (15.635s) (coverage: 32.0% of statements)
=== Failed
=== FAIL: pkg/ruler/base TestRuler_PrometheusAlerts (0.00s)
level=info msg="ruler up and running"
testing.go:1[23](https://github.com/grafana/loki/actions/runs/9265942171/job/25489088416?pr=13032#step:5:24)1: TempDir RemoveAll cleanup: unlinkat /tmp/TestRuler_PrometheusAlerts314236595/001: directory not empty
DONE 283 tests, 1 failure in 94.108s
Error: Process completed with exit code 1. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[docs team] LGTM
Co-authored-by: J Stickler <[email protected]> (cherry picked from commit 1432a3e)
Added Ingesting basics for Loki video to
_index.md
of the Send Data directory. Also Updated Grafana Agent to Grafana Alloy.Checklist
CONTRIBUTING.md
guide (required)feat
PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.docs/sources/setup/upgrade/_index.md
production/helm/loki/Chart.yaml
and updateproduction/helm/loki/CHANGELOG.md
andproduction/helm/loki/README.md
. Example PRdeprecated-config.yaml
anddeleted-config.yaml
files respectively in thetools/deprecated-config-checker
directory. Example PR