-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(helm): fix extraObjects #13107
fix(helm): fix extraObjects #13107
Conversation
1476b9e
to
8334179
Compare
@MichelHollands could you please take a look at this patch? |
Maybe @TheRealNoob would be interested in having a look at it as well. |
8334179
to
14f1ff6
Compare
@MichelHollands @jeschkies is there a way to help merging this PR? The change is really small and it fixes a real issue |
Thank you :) |
@hervenicol sorry I missed this notification. Apologies for not catching this! Thank you for fixing it |
@TheRealNoob I think we forgot to bump the chart version in this PR |
Co-authored-by: Herve Nicol <[email protected]> Co-authored-by: Karsten Jeschkies <[email protected]>
What this PR does / why we need it:
Fixes a regression introduced with #12397
When we had multiple extraObjects the rendering was missing linefeed before the separation triple-dashes (
---
).Like here:
With the fix it looks like this:
Special notes for your reviewer:
Checklist
CONTRIBUTING.md
guide (required)feat
PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.docs/sources/setup/upgrade/_index.md
production/helm/loki/Chart.yaml
and updateproduction/helm/loki/CHANGELOG.md
andproduction/helm/loki/README.md
. Example PRdeprecated-config.yaml
anddeleted-config.yaml
files respectively in thetools/deprecated-config-checker
directory. Example PR