fix: Fix bloom deleter PR after merge #13167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chaudum
approved these changes
Jun 7, 2024
grobinson-grafana
approved these changes
Jun 7, 2024
| @@ -476,7 +473,7 @@ func (p *Planner) loadTenantWork( | |||
|
|
|||
| // If this is the first this we see this table, initialize the map | |||
| if tenantTableWork[table] == nil { | |||
| tenantTableWork[table] = make(map[string][]v1.FingerprintBounds, tenants.Len()) | |||
| tenantTableWork[table] = make(map[string][]v1.FingerprintBounds, tenants.Remaining()) | |||
There was a problem hiding this comment.
I don't know this code too well, but I assume the behavior of Len and Remaining here is the same – i.e. Remaining doesn't do additional filtering, for example.
salvacorts
deleted the
salvacorts/bloom-refactor/planner-delete-tombstones-fix
branch
This was referenced Jun 10, 2024
This was referenced Jul 3, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #13153. Reimplemented
outdatedMetasas it's currently implemented in the bloomcompactor pkg:loki/pkg/bloomcompactor/versioned_range.go
Line 213 in fbe7c55
nit: I'm removing the err returned by
outdatedMetassince it's always nil.