-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(operator): add alertmanager client config to ruler template #13182
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM and much appreciated closing this issue. I believe this is a big miss in the code base due to the fact that most of the operator users are using the alertmanager client config per tenant.
Requesting just a quick make bundle-all
to update the bundles before releasing this.
@periklis done. |
Sorry forgot to point to |
Should be fine now. |
@aleert Thank you very much for your first contribution to the Loki Operator. If you happen to have time, please join on the Grafana Community Slack chanel #loki-operator-dev for a quick chat to tell us where and how you use the Loki Operator. I would appreciate feedback on improvements and future direction. |
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #13181
Checklist
CONTRIBUTING.md
guide (required)feat
PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.docs/sources/setup/upgrade/_index.md
production/helm/loki/Chart.yaml
and updateproduction/helm/loki/CHANGELOG.md
andproduction/helm/loki/README.md
. Example PRdeprecated-config.yaml
anddeleted-config.yaml
files respectively in thetools/deprecated-config-checker
directory. Example PR