Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(operator): Watch for CredentialsRequests on CCOAuthEnv only #13299

Merged
merged 1 commit into from
Jul 4, 2024

Conversation

periklis
Copy link
Collaborator

What this PR does / why we need it:
Registers the controller watcher for CredentialRequest only when CCOAuthEnv: true OpenShift environments. Resolves issue:

{"_ts":"2024-04-24T16:02:28.027229225Z","_level":"0","_component":"loki-operator_controller-runtime_source_EventHandler","_message":"failed to get informer from cache","_error":{"msg":"failed to get API group resources: unable to retrieve the complete list of server APIs: cloudcredential.openshift.io/v1: the server could not find the requested resource"}}

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
    • Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such, feat PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • For Helm chart changes bump the Helm chart version in production/helm/loki/Chart.yaml and update production/helm/loki/CHANGELOG.md and production/helm/loki/README.md. Example PR
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR

@periklis periklis self-assigned this Jun 24, 2024
@periklis periklis requested review from xperimental and a team as code owners June 24, 2024 18:51
periklis added a commit to openshift/loki that referenced this pull request Jun 25, 2024
Copy link
Collaborator

@JoaoBraveCoding JoaoBraveCoding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Collaborator

@xperimental xperimental left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on CRC 👍

Does this need an entry in the changelog?

edit: Oh wait. I just remembered. We're not doing a manual changelog here anymore. Never mind, then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants