feat: Drain uses different tokenizer based on log format #13384
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benclive
reviewed
Jul 4, 2024
| for !t.dec.EOL() && t.dec.ScanKeyval() { | ||
| key := t.dec.Key() | ||
| if isVariableField(key) { | ||
| tokens = append(tokens, unsafeString(t.dec.Key()), t.varReplace) |
There was a problem hiding this comment.
Interesting that this works - I thought that ScanKeyval reused those values after every call but it seems tthat it doesn't?
There was a problem hiding this comment.
It returns either a copy if it needs to decode quoted bytes or just a subslice.
| buf := bytes.NewBuffer(make([]byte, 0, 1024)) | ||
| enc := gologfmt.NewEncoder(buf) | ||
| for i := 0; i < len(tokens); i += 2 { | ||
| k, v := tokens[i], tokens[i+1] |
There was a problem hiding this comment.
How does this handle multi-word values? Are they a single token?
There was a problem hiding this comment.
correct they are.
benclive
approved these changes
Jul 4, 2024
This was referenced Jul 8, 2024
This was referenced Aug 15, 2024
This was referenced Oct 14, 2024
This was referenced Oct 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This replace the tokenizer with special one depending on the log format. It also discard json logs.
I also improve performance by removing most of allocations
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Checklist
CONTRIBUTING.mdguide (required)featPRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.docs/sources/setup/upgrade/_index.mdproduction/helm/loki/Chart.yamland updateproduction/helm/loki/CHANGELOG.mdandproduction/helm/loki/README.md. Example PRdeprecated-config.yamlanddeleted-config.yamlfiles respectively in thetools/deprecated-config-checkerdirectory. Example PR