Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: exclude and from creating new tokens in patterns #13395

Merged

Conversation

benclive
Copy link
Contributor

@benclive benclive commented Jul 3, 2024

What this PR does / why we need it:
After reviewing the patterns generated in more environments, we've identified some punctuation which shouldn't split tokens.

  • Excluding : and . as token split points - this makes timestamps + IP addresses tokenize as single tokens which makes it easier for Drain to categorise them.
  • Some tokens won't be split as much which should improve performance a little.
  • As usual, there may be some logs for which this causes problems.
  • JSON logs are (luckily) unaffected because well-formed json will still split the quotes surrounding keys.

@benclive benclive requested a review from a team as a code owner July 3, 2024 10:53
Copy link
Contributor

@cyriltovena cyriltovena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cyriltovena cyriltovena merged commit 8c8454b into main Jul 3, 2024
61 checks passed
@cyriltovena cyriltovena deleted the benclive/exclude-some-puncutation-from-pattern-tokens branch July 3, 2024 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants