Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: exclude in pattern tokens #13397

Merged
merged 1 commit into from
Jul 3, 2024
Merged

feat: exclude in pattern tokens #13397

merged 1 commit into from
Jul 3, 2024

Conversation

benclive
Copy link
Contributor

@benclive benclive commented Jul 3, 2024

What this PR does / why we need it:

  • Excludes '/' from generating a new token when splitting on punctuation.
  • This means URLs and file paths will be tokenized as a single item.

@benclive benclive requested a review from a team as a code owner July 3, 2024 12:36
cyriltovena
cyriltovena approved these changes Jul 3, 2024
View reviewed changes
Copy link
Contributor

@cyriltovena cyriltovena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cyriltovena cyriltovena merged commit e612dd3 into main Jul 3, 2024
61 checks passed
@cyriltovena cyriltovena deleted the benclive/exclude-slash-in-pattern-tokens branch July 3, 2024 13:09
This was referenced Jul 8, 2024
Closed
Closed
@loki-gh-app loki-gh-app bot mentioned this pull request Jul 15, 2024
Closed
@loki-gh-app loki-gh-app bot mentioned this pull request Jul 22, 2024
Closed
This was referenced Aug 15, 2024
Open
Open
@loki-gh-app loki-gh-app bot mentioned this pull request Sep 9, 2024
Merged
@loki-gh-app loki-gh-app bot mentioned this pull request Sep 23, 2024
Open
@loki-gh-app loki-gh-app bot mentioned this pull request Sep 30, 2024
Open
@loki-gh-app loki-gh-app bot mentioned this pull request Oct 7, 2024
Open
This was referenced Oct 14, 2024
Open
Closed
This was referenced Oct 21, 2024
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cyriltovena cyriltovena cyriltovena approved these changes

Assignees
No one assigned
Labels
size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@benclive @cyriltovena