Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: improve placeholder replacement of byte sizes #13508

Merged
merged 1 commit into from
Jul 12, 2024

Conversation

na--
Copy link
Member

@na-- na-- commented Jul 12, 2024

What this PR does / why we need it:

It improves the placeholder replacement for byte sizes with spaces in the middle (e.g. 3.14 GiB, 2 KiB, etc.) and in plain bytes (e.g. 3b, 1337 B, etc.).

This was especially problematic for some lines like the distributor's push request parsed messages, see example in the tests.

Special notes for your reviewer:

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Tests updated
  • Title matches the required conventional commits format, see here
    • Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such, feat PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.

@na-- na-- requested a review from a team as a code owner July 12, 2024 12:32
@MasslessParticle MasslessParticle merged commit ac284ca into main Jul 12, 2024
61 checks passed
@MasslessParticle MasslessParticle deleted the ned/improve-bytesize-replacement branch July 12, 2024 15:20
@MasslessParticle MasslessParticle restored the ned/improve-bytesize-replacement branch July 12, 2024 16:17
@MasslessParticle MasslessParticle deleted the ned/improve-bytesize-replacement branch July 12, 2024 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants