feat: Remove flush loop and queue from Ingester RF-1 #13538
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -141,7 +145,6 @@ func NewManager(cfg Config, metrics *Metrics) (*Manager, error) { | |||
| metrics: metrics.ManagerMetrics, | |||
| available: list.New(), | |||
| pending: list.New(), | |||
| shutdown: make(chan struct{}), | |||
There was a problem hiding this comment.
Removed as it wasn't used.
| m.mu.Lock() | ||
| defer m.mu.Unlock() | ||
| m.closed = true | ||
| if m.available.Len() > 0 { |
There was a problem hiding this comment.
This is duplicate code. I will refactor it in a follow up PR. But I wanted to show how it works here.
grobinson-grafana
force-pushed
the
grobinson/remove-loop-and-queue
branch
from
414c32e
to
a338260
Compare
This commit removes the flush loop and flush queue from Ingester RF-1. This code is from the original ingester code, and is no longer needed since we have the WAL Manager.
grobinson-grafana
force-pushed
the
grobinson/remove-loop-and-queue
branch
from
a338260
to
cfaa574
Compare
| op := o.(*flushOp) | ||
|
|
||
| if it == nil { | ||
| // TODO: Do something more clever here instead. |
There was a problem hiding this comment.
I was concerned this would increase CPU usage, but having tested it in dev it doesn't have much effect at all.
There was a problem hiding this comment.
I think next pending should be blocking instead
There was a problem hiding this comment.
I thought about it too! I'll take a look at how to use sync.Cond to achieve this.
This was referenced Aug 15, 2024
This was referenced Oct 14, 2024
This was referenced Oct 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This commit removes the flush loop and flush queue from Ingester RF-1. This code is from the original ingester code, and is no longer needed since we have the WAL Manager.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Checklist
CONTRIBUTING.mdguide (required)featPRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.docs/sources/setup/upgrade/_index.mdproduction/helm/loki/Chart.yamland updateproduction/helm/loki/CHANGELOG.mdandproduction/helm/loki/README.md. Example PRdeprecated-config.yamlanddeleted-config.yamlfiles respectively in thetools/deprecated-config-checkerdirectory. Example PR