Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add baseline rf1 querier component #13639

Merged
merged 3 commits into from
Jul 24, 2024

Conversation

benclive
Copy link
Contributor

@benclive benclive commented Jul 24, 2024

What this PR does / why we need it:

  • Adds a new cloned querier component for the RF1 work
  • This currently does the same as the existing querier except the tail endpoints return errors - it will be massively updated as we go.
  • Enabling this component replaces the existing querier during init due to taking over the same APIs, so its only enabled if either the target is set to "querier-rf1" or the target is "ALL" and the "querier-rf1.enabled" flag is set.
    • This isn't super robust - I'd like to find a clearer way which doesn't risk the chance of accidentally disabling the existing querier implementation when this is enabled.

@benclive benclive requested a review from a team as a code owner July 24, 2024 10:36
@github-actions github-actions bot added the type/docs Issues related to technical documentation; the Docs Squad uses this label across many repositories label Jul 24, 2024
Copy link
Contributor

@cyriltovena cyriltovena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@benclive benclive merged commit 3a99b69 into main Jul 24, 2024
62 checks passed
@benclive benclive deleted the benclive/add-rf1-querier-baseline branch July 24, 2024 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/XXL type/docs Issues related to technical documentation; the Docs Squad uses this label across many repositories
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants