feat: ability to ignore cache for volume queries #13945
Merged
+264
−197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MasslessParticle
approved these changes
Aug 23, 2024
cstyan
reviewed
Aug 23, 2024
| @@ -413,6 +413,9 @@ func (Codec) DecodeRequest(_ context.Context, r *http.Request, _ []string) (quer | |||
| Step: 0, | |||
| TargetLabels: req.TargetLabels, | |||
| AggregateBy: req.AggregateBy, | |||
| CachingOptions: queryrangebase.CachingOptions{ | |||
There was a problem hiding this comment.
should we document that these are now not cached by default? (and caching of them is not configurable by the user if we're hard coding this here?)
There was a problem hiding this comment.
oh, hmm, I missed this.... how are they not cached by default? My intent here was to keep the behavior but allow them to not be cached by setting the Cache-Control header.
There was a problem hiding this comment.
Nevermind, I misunderstood based on the field name. I assumed Disabled would only be present if the results caching was disabled. Missing the historical context of why the field is named Disabled and not something like ShouldCache.
cstyan
approved these changes
Aug 24, 2024
grafanabot
pushed a commit
that referenced
this pull request
Aug 26, 2024
(cherry picked from commit b1dc076)
This was referenced Oct 14, 2024
This was referenced Oct 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Add caching option to volume requests so we can issue queries that ignore the results cache (important for some performance testing and tuning)