-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Implement WAL segment ingestion via Kafka with partition ring #14043
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Set up Kafka consumer for WAL segments - Implement partition ring for managing assignments - Add delayed downscale endpoint for graceful partition consumption - Implement 10s block building and flushing to metastore/object storage - First pass on the encoding/decoding of push request to Kafka
github-actions
bot
added
type/docs
Issues related to technical documentation; the Docs Squad uses this label across many repositories
and removed
size/XXL
labels
Sep 4, 2024
cyriltovena
changed the title
WIP: Implement WAL segment ingestion via Kafka with partition ring
feat: Implement WAL segment ingestion via Kafka with partition ring
Sep 5, 2024
grobinson-grafana
approved these changes
Sep 6, 2024
Co-authored-by: George Robinson <[email protected]>
…to kafka-wal-block
pkg/kafka/ingester/consumer.go
Outdated
} | ||
|
||
// Flush writes the accumulated data to storage and updates the metadata store | ||
func (c *consumer) Flush(ctx context.Context) error { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should add a check for input size so we don't write empty blocks.
// Flush writes the accumulated data to storage and updates the metadata store
func (c *consumer) Flush(ctx context.Context) error {
+ if c.writer.InputSize() == 0 {
+ return nil
+ }
+
start := time.Now()
c.metrics.flushesTotal.Add(1)
defer func() { c.metrics.flushDuration.Observe(time.Since(start).Seconds()) }()
This was referenced Oct 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
CONTRIBUTING.md
guide (required)feat
PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.docs/sources/setup/upgrade/_index.md
production/helm/loki/Chart.yaml
and updateproduction/helm/loki/CHANGELOG.md
andproduction/helm/loki/README.md
. Example PRdeprecated-config.yaml
anddeleted-config.yaml
files respectively in thetools/deprecated-config-checker
directory. Example PR