Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Expand matching for additional variations #14221

Merged
merged 1 commit into from
Sep 23, 2024

Conversation

paul1r
Copy link
Collaborator

@paul1r paul1r commented Sep 23, 2024

What this PR does / why we need it:
Additional flavors, as seen here

Which issue(s) this PR fixes:
Follow on to #14217

Special notes for your reviewer:

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
    • Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such, feat PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • For Helm chart changes bump the Helm chart version in production/helm/loki/Chart.yaml and update production/helm/loki/CHANGELOG.md and production/helm/loki/README.md. Example PR
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR

@paul1r paul1r requested a review from a team as a code owner September 23, 2024 13:46
@paul1r paul1r merged commit 71d7291 into main Sep 23, 2024
64 checks passed
@paul1r paul1r deleted the paul1r/adjust_gcs_client_timeout branch September 23, 2024 14:03
@paul1r paul1r added type/bug Somehing is not working as expected backport release-3.2.x labels Sep 23, 2024
loki-gh-app bot pushed a commit that referenced this pull request Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport release-3.2.x size/XS type/bug Somehing is not working as expected
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants