feat(operator)!: Provide default OTLP attribute configuration #14410
+3,294
−2,424
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… openshift-logging tenancy - Extend API for default OTLP label set - Disable autodetection of service.name - Update non-otlp config tests - Simplify OTLP attribute configuration - Remove validator code - Content-assist for runtime config - Add openshift-logging defaults - Only add ignore_defaults to config if needed - Use Loki default OTLP attributes when none are specified
xperimental
force-pushed
the
otlp-defaults
branch
from
3811195
to
3a43315
Compare
xperimental
force-pushed
the
otlp-defaults
branch
from
80c45e9
to
207d3bd
Compare
xperimental
requested review from
periklis,
JoaoBraveCoding and
a team
as code owners
periklis
reviewed
Oct 15, 2024
| ResourceAttributes: []config.OTLPAttribute{ | ||
| { | ||
| Action: config.OTLPAttributeActionStreamLabel, | ||
| Regex: "openshift\\.labels\\..+", |
There was a problem hiding this comment.
Question: What is considered an OpenShift Label here?
There was a problem hiding this comment.
I don't think there are any of these labels at the moment. This might be an extension point. I meant to write a question about this in the data-model PR, but I forgot. The attribute configuration itself is from the data-model repository.
|
Updated the PR to reflect some of the changes we discussed during the daily. The CRD already reflects the final view, but the "copy global to tenant configuration" part is still missing. The current version still provides defaults useful for testing with CLO, though. |
|
Updated with the changes discussed on Friday. ✔️ |
periklis
reviewed
Oct 22, 2024
xperimental
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
The main purpose of this PR is to provide a default set of OTLP attributes that will be persisted when using LokiStack in
openshift-loggingtenancy mode.This PR also changes the API for specifying an OTLP attribute configuration in LokiStack to make it easier to use.
Which issue(s) this PR fixes:
LOG-6147
Special notes for your reviewer:
Checklist
CONTRIBUTING.mdguide (required)