Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

profiles from python sdk have -1 as line number #3336

Closed
korniltsev opened this issue Jun 5, 2024 · 0 comments · Fixed by #3337
Closed

profiles from python sdk have -1 as line number #3336

korniltsev opened this issue Jun 5, 2024 · 0 comments · Fixed by #3337

Comments

@korniltsev
Copy link
Collaborator

The underlying pprof from pyspy has line numbers

pyroscope/pkg/og/convert/pprof/profile.go

Line 256 in 7faadde

const lineNumber = -1

Suggested options to fix:

  1. properly render line number on frontend
  2. rewrite pprof to include line number in the Function.Name
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(ingest): line numbers for pyspy grafana/pyroscope
1 participant
@korniltsev