-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add release-please action #183
Conversation
954bb3e
to
46e2b32
Compare
e02b0a7
to
d35ae62
Compare
cd8acb5
to
d558398
Compare
5d59700
to
f2067a2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just looking at the docs (interesting project, haven't seen it before)... should we use a manifest? mentions it's for monorepos - maybe we could release the stuff separately then?
wanted to make it as simple as possible to begin with, I think the manifest is great but overpowered 😁 |
ah yeah, the main thing I'm thinking is that when we make releases it should result in Dependabot PRs to people who use our actions, and creating those when there aren't actual changes to deploy... is not that friendly |
We could have a play with the single-release thing and add a manifest later if you want? |
3132ab9
to
0d5cac8
Compare
75aaaba
to
895efa2
Compare
This PR is responsible for adding the
googleapis/release-please-action
. This action is used to make ashared-workflows
repo release and tag.Releasing and tagging this repo will help add automations around updating the commit hashes of the teams/individuals who use the workflows.
First tag and release: https://github.com/grafana/shared-workflows/releases/tag/v1.0.0
Changelog: https://github.com/grafana/shared-workflows/blob/main/CHANGELOG.md
Notice that there are 3 tags,
v1
,v1.0
andv1.0.0
. This happens because there are users who prefer to use either a major, minor or a patch version of any given workflow. We create all three of them in order to make it able for the user to get all the changes without pinning their versions.Note:
In order for release-please-action to work, the PRs need to follow the conventional commits specification, thus we now use the
lint-pr-title
action for pull requests in this repo.