Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add release-please action #183

Merged
merged 15 commits into from
Jul 16, 2024
Merged

feat: add release-please action #183

merged 15 commits into from
Jul 16, 2024

Conversation

dsotirakis
Copy link
Contributor

@dsotirakis dsotirakis commented Jul 15, 2024

This PR is responsible for adding the googleapis/release-please-action. This action is used to make a shared-workflows repo release and tag.
Releasing and tagging this repo will help add automations around updating the commit hashes of the teams/individuals who use the workflows.

First tag and release: https://github.com/grafana/shared-workflows/releases/tag/v1.0.0
Changelog: https://github.com/grafana/shared-workflows/blob/main/CHANGELOG.md

Notice that there are 3 tags, v1, v1.0 and v1.0.0. This happens because there are users who prefer to use either a major, minor or a patch version of any given workflow. We create all three of them in order to make it able for the user to get all the changes without pinning their versions.

Note:

In order for release-please-action to work, the PRs need to follow the conventional commits specification, thus we now use the lint-pr-title action for pull requests in this repo.

@dsotirakis dsotirakis self-assigned this Jul 15, 2024
@dsotirakis dsotirakis changed the title [WIP] feat: Add release-please action [WIP] Unconventional: Add release-please action Jul 15, 2024
@dsotirakis dsotirakis force-pushed the add-release-please-action branch 2 times, most recently from e02b0a7 to d35ae62 Compare July 15, 2024 12:14
@dsotirakis dsotirakis changed the title [WIP] Unconventional: Add release-please action feat(actions): Add release-please action Jul 15, 2024
@dsotirakis dsotirakis changed the title feat(actions): Add release-please action feat(actions): add release-please action Jul 15, 2024
@dsotirakis dsotirakis changed the title feat(actions): add release-please action feat: add release-please action Jul 15, 2024
@dsotirakis dsotirakis force-pushed the add-release-please-action branch 5 times, most recently from cd8acb5 to d558398 Compare July 15, 2024 14:00
@dsotirakis dsotirakis marked this pull request as ready for review July 15, 2024 14:17
@dsotirakis dsotirakis requested a review from a team as a code owner July 15, 2024 14:17
@dsotirakis dsotirakis force-pushed the add-release-please-action branch 2 times, most recently from 5d59700 to f2067a2 Compare July 15, 2024 14:22
Copy link
Member

@iainlane iainlane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just looking at the docs (interesting project, haven't seen it before)... should we use a manifest? mentions it's for monorepos - maybe we could release the stuff separately then?

.github/workflows/release.yml Outdated Show resolved Hide resolved
.github/workflows/release.yml Outdated Show resolved Hide resolved
@dsotirakis
Copy link
Contributor Author

just looking at the docs (interesting project, haven't seen it before)... should we use a manifest? mentions it's for monorepos - maybe we could release the stuff separately then?

wanted to make it as simple as possible to begin with, I think the manifest is great but overpowered 😁
will have a look anyway.

@iainlane
Copy link
Member

just looking at the docs (interesting project, haven't seen it before)... should we use a manifest? mentions it's for monorepos - maybe we could release the stuff separately then?

wanted to make it as simple as possible to begin with, I think the manifest is great but overpowered 😁 will have a look anyway.

ah yeah, the main thing I'm thinking is that when we make releases it should result in Dependabot PRs to people who use our actions, and creating those when there aren't actual changes to deploy... is not that friendly

README.md Outdated Show resolved Hide resolved
commitlint.config.js Outdated Show resolved Hide resolved
@iainlane
Copy link
Member

We could have a play with the single-release thing and add a manifest later if you want?

@dsotirakis dsotirakis added this pull request to the merge queue Jul 16, 2024
@dsotirakis dsotirakis removed this pull request from the merge queue due to a manual request Jul 16, 2024
README.md Outdated Show resolved Hide resolved
@dsotirakis dsotirakis requested a review from zerok July 16, 2024 12:41
@dsotirakis dsotirakis added this pull request to the merge queue Jul 16, 2024
Merged via the queue into main with commit 0c6afbf Jul 16, 2024
7 checks passed
@dsotirakis dsotirakis deleted the add-release-please-action branch July 16, 2024 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants