fix(renovate): fix action versions, add more triggers #249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsotirakis
approved these changes
Sep 19, 2024
iainlane
force-pushed
the
iainlane/renovate-gha-semver
branch
from
0f878bf
to
0bfed61
Compare
iainlane
changed the title
iainlane
force-pushed
the
iainlane/renovate-gha-semver
branch
5 times, most recently
from
2e6f23a
to
693491e
Compare
When referencing actions, we'll do: ```yaml uses: foo/bar-action@123456789 # v1.2.3 ``` to reference by SHA but still say what the version was. Dependabot supports updating these comments when creating bumps, but Renovate doesn't do this when the comment points to the wrong version. We had two cases of that in `codeql-action` and `vault-action`. Here we fix both. Also, it's easier to test if we can kick off runs manually and if Renovate triggers when its config or workflow are changed, so add triggers for that. [preset]: https://docs.renovatebot.com/presets-helpers/#helperspingithubactiondigeststosemver
iainlane
force-pushed
the
iainlane/renovate-gha-semver
branch
from
693491e
to
be34eae
Compare
|
@dsotirakis can you check again please? what I thought initially was wrong, and really it was that some of the version comments were incorrect! |
|
oh what sorry, I thought that would not merge until you had re-reviewed 😢 |
This was referenced Sep 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When referencing actions, we'll do:
to reference by SHA but still say what the version was. Dependabot supports updating these comments when creating bumps, but Renovate doesn't do this when the comment points to the wrong version.
We had two cases of that in
codeql-actionandvault-action. Here we fix both.Also, it's easier to test if we can kick off runs manually and if Renovate triggers when its config or workflow are changed, so add triggers for that.