feat(trigger-argo-workflow): support {dev,ops}-aws instances and get repo-specifc paths #269
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iainlane
changed the title
iainlane
force-pushed
the
iainlane/argo-wf-dev-aws
branch
2 times, most recently
from
ba64d86
to
361c6f2
Compare
…repo-specifc paths We're migrating our Argo Workflows environment internally, and for that we currently have parallel deployments. We've namespaced the secrets needed to trigger in each cluster. This PR modifies to allow the new `dev-aws` instance and fetch the cluster-scoped secrets. To save time for the production migration later, we'll also teach everything about `ops-aws` now, even though it doesn't exist yet.
iainlane
force-pushed
the
iainlane/argo-wf-dev-aws
branch
from
361c6f2
to
b576281
Compare
zerok
approved these changes
Sep 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're migrating our Argo Workflows environment internally, and for that we currently have parallel deployments. We've namespaced the secrets needed to trigger in each cluster. This PR modifies to allow the new
dev-awsinstance and fetch the cluster-scoped secrets.To save time for the production migration later, we'll also teach everything about
ops-awsnow, even though it doesn't exist yet.