Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PRs can still be merged with failing workflows #478

Open
iainlane opened this issue Oct 16, 2024 · 1 comment
Open

PRs can still be merged with failing workflows #478

iainlane opened this issue Oct 16, 2024 · 1 comment
Assignees

Comments

@iainlane
Copy link
Member

We had this failing run but we still merged #147 and it broke users.

It's because this check isn't required. Conditional checks can't simply be made required, or else they will block pull requests which don't change the files they trigger on.

Possible fixes:

  1. Make checks unconditional, just run them always
  2. Move the conditionality to runtime using a "changed files" type of action
  3. Use our deployment of https://github.com/palantir/policy-bot and make these checks conditional if triggered by writing a .policy.yml containing rules that replicate the file triggers, or using a generator (we have one internally in deployment_tools - we could open source that by moving it to this repo).
@Elfo404
Copy link
Member

Elfo404 commented Nov 5, 2024

Option 3 should not be viable due to #497 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants