Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cache the first N cache index page requests #587

Closed
joe-elliott opened this issue Mar 11, 2021 · 2 comments
Closed

Cache the first N cache index page requests #587

joe-elliott opened this issue Mar 11, 2021 · 2 comments
Labels
stale Used for stale issues / PRs

Comments

@joe-elliott
Copy link
Member

Is your feature request related to a problem? Please describe.
#577 removed indexes from the caching. Overall this is a good thing as a large percentage of our indexes didn't fit into our memcached instance and it generated a lot of errors.

Let's reenable index caching.

Describe the solution you'd like
With #577 we introduced a binary search over a paged index. This means that the first 2 or 3 levels of the search are going to be "hot" in that the same pages are repeatedly accessed while resolving the search. Let's cache the first few index requests on every search.

My gut says this configurable value should default to 2.

@joe-elliott joe-elliott added this to the kv store complete milestone Mar 11, 2021
@annanay25
Copy link
Contributor

annanay25 commented May 6, 2021

At our current scale we have 6000 blocks * 2 pages * 1/4MB per page = 3GB. Let's do this!

@github-actions
Copy link
Contributor

github-actions bot commented Dec 3, 2022

This issue has been automatically marked as stale because it has not had any activity in the past 60 days.
The next time this stale check runs, the stale label will be removed if there is new activity. The issue will be closed after 15 days if there is no new activity.
Please apply keepalive label to exempt this Issue.

@github-actions github-actions bot added the stale Used for stale issues / PRs label Dec 3, 2022
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Dec 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale Used for stale issues / PRs
Projects
None yet
Development

No branches or pull requests

2 participants