Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change standard example port to 3200 #770

Closed
joe-elliott opened this issue Jun 16, 2021 · 2 comments · Fixed by #809
Closed

Change standard example port to 3200 #770

joe-elliott opened this issue Jun 16, 2021 · 2 comments · Fixed by #809
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@joe-elliott
Copy link
Member

All of our examples use port 3100 as the Tempo http port. This collides with the standard example in Loki that also uses 3100. This occasionally confuses users when they attempt to run standard Loki and Tempo configs in the same network namespace.

Change all in repo examples/docs/whatever to use 3200.

@joe-elliott joe-elliott changed the title Change example port to 3200 Change standard example port to 3200 Jun 16, 2021
@MurzNN
Copy link
Contributor

MurzNN commented Jul 13, 2021

Yeah, I got very confused when see same default port on Tempo and Loki docs, especially when Tempo also needs loki-url option to same port in example/docker-compose/loki/docker-compose.yaml :)

@joe-elliott joe-elliott added good first issue Good for newcomers help wanted Extra attention is needed labels Jul 13, 2021
@MurzNN
Copy link
Contributor

MurzNN commented Jul 13, 2021

I created PR with this replacement: #809 - hope I'm not replace more than needed. 3100 port, that mentioned with Loki, is kept.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants