Move Sobek entirely out of the business logic

[inancgumus]

What?

Move Sobek entirely out of the business logic.

Why?

• Prevent Sobek data races.
• Better type-safety using native Go constructs.
• Developer productivity increase.
• Separation of concerns.
• Moving Sobek handling to the mapping layer will make the code easy to reason about, reduce the business logic's Sobek dependency, and simplify the business logic code and tests.
• Having Sobek in the business logic requires constant encoding and decoding.

Desobekifying Sobek transformation

Besides moving the calling of Sobek option parsing in the business logic, we also plan to move the Sobek-dependent option parsing part out of the business logic. Once we finish doing the same with the rest of the option parsing, we can entirely remove the Sobek dependency from the business logic.

We currently parse Sobek values into our business logic types, but the parsing dependency is in an unrelated package (common). To enhance maintainability, we move the parsing process and keep related components together (in the mapping layer). Additionally, we could implement a Validate method for the business types (in the common package) to check their validity separately from the Sobek transformation.

Moreover, we use pointers quite liberally, which is not good in terms of reduced performance and also because of many nil-pointer panics. Also, since our module is highly current, it's dangerous to have so many pointers around. So, another goal would be to get rid of as many pointer-ed options as possible to boost stability even more.

See #1510 for an example.

Tasks

Tasks

Beta Give feedback

1. De-sobekify ElementHandle methods #1272
   +0
2. De-sobekify Frame methods #1271
   +0
3. De-sobekify Page methods #1273
   +0
4. De-sobekify Locator methods #1274
   +0
5. De-sobekify Mouse methods #1525
   0 of 2
   refactor stability +2
6. De-sobekify BrowserContext methods #1270
   12 of 13
   mapping stability +2
   
7. Remove NetworkManager.ExtraHTTPHeaders that returns a sobek.Value #1282
   1 of 2
   maintenance +1
   
8. De-sobekify Keyboard option parsing out of common #1522
   1 of 2
   refactor stability +2
   
9. Discuss: Should we add option parsing to the trace spans? #1393
   +0
10. De-sobekify Browser methods #1269
    2 of 2
    mapping stability +2
    
11. De-sobekify Request methods #1275
    2 of 2
    maintenance stability +2
    
12. De-sobekify Keyboard methods #1277
    2 of 2
    refactor stability +2
    
13. De-sobekify Connection.Close method? #1281
    2 of 2
    refactor stability +2
    
14. Refactor Sobek out of browserContext.addinitscript #1228
    refactor stability +2
    
15. Refactor Sobek out of screenshots and byte pointer changes #1198
    refactor stability +2
    

Related PR(s)/Issue(s)

#271