Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HtmlFetcher does not handle gzip compression #238

Open
kqr opened this issue Aug 11, 2015 · 2 comments · May be fixed by #237
Open

HtmlFetcher does not handle gzip compression #238

kqr opened this issue Aug 11, 2015 · 2 comments · May be fixed by #237

Comments

@kqr
Copy link

kqr commented Aug 11, 2015

Some servers force gzip compression on their content, which HtmlFetcher does not deal gracefully with because urllib2 assumes non-compressed content. Cheapest/easiest solution would be to check the encoding header on the response and decompress with zlib if it's gzipped. More ambitious/heavy solution would be to move over to something like requests rather than urllib2.
@kqr kqr linked a pull request Aug 11, 2015 that will close this issue
Open
@Lol4t0
Copy link

Lol4t0 commented Jan 13, 2016

Requests: 7292933

@kqr
Copy link
Author

kqr commented Jan 13, 2016

Awesome! Let's hope it gets merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

add gzip deflation to HtmlFetcher AGoodId/python-goose
2 participants
@kqr @Lol4t0