You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Nov 24, 2018. It is now read-only.
Following up #84 (comment), we need to abstract the shared code between .screenshot() and .pdf() for saving files to local disk or S3. The abstraction should also incorporate the ability to specify S3 key or local disk path (#83)
There might also be overlap/abstraction possible for/in preparation of #48.
adieuadieu
changed the title
Abstract the shared code between .screenshot() and .pdf()
Abstract the shared file-saving code between .screenshot() and .pdf()
Jul 31, 2017
Following up #84 (comment), we need to abstract the shared code between
.screenshot()
and.pdf()
for saving files to local disk or S3. The abstraction should also incorporate the ability to specify S3 key or local disk path (#83)There might also be overlap/abstraction possible for/in preparation of #48.
Acceptance Criteria
Buffer.from()
asnew Buffer()
is deprecated API in newer Node.js versionsThe text was updated successfully, but these errors were encountered: