Skip to content
This repository has been archived by the owner on Nov 24, 2018. It is now read-only.

Abstract the shared file-saving code between .screenshot() and .pdf() #113

Closed
4 tasks done
adieuadieu opened this issue Jul 31, 2017 · 1 comment
Closed
4 tasks done

Comments

@adieuadieu
Copy link
Collaborator

adieuadieu commented Jul 31, 2017

Following up #84 (comment), we need to abstract the shared code between .screenshot() and .pdf() for saving files to local disk or S3. The abstraction should also incorporate the ability to specify S3 key or local disk path (#83)

There might also be overlap/abstraction possible for/in preparation of #48.

Acceptance Criteria

@adieuadieu adieuadieu changed the title Abstract the shared code between .screenshot() and .pdf() Abstract the shared file-saving code between .screenshot() and .pdf() Jul 31, 2017
@seangransee seangransee mentioned this issue Jul 31, 2017
@elisherer
Copy link
Contributor

I answered some of the requirements with #137

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants