Skip to content
This repository has been archived by the owner on Nov 24, 2018. It is now read-only.

Allow setting of headers #31

Closed
joelgriffith opened this issue Jul 26, 2017 · 11 comments
Closed

Allow setting of headers #31

joelgriffith opened this issue Jul 26, 2017 · 11 comments

Comments

@joelgriffith
Copy link
Contributor

https://chromedevtools.github.io/devtools-protocol/tot/Network/#method-setExtraHTTPHeaders

Consumers should probably be allowed to set headers for requests (helps with functional tests so that you can auth once and use headers on subsequent requests).

@schickling
Copy link
Owner

That's a great idea and could also be used for #29 maybe.

@amjd
Copy link

amjd commented Aug 4, 2017

I would second this as well. Support for working with request and response headers is an important feature that's currently missing.

@wade0317
Copy link

How could i get the header form chromeless? Now cookie() is available, is there any api for header ?

@gios
Copy link

gios commented Oct 30, 2017

Can we merge this pull request in master and publish this changes with an updated version?

@jahed
Copy link

jahed commented Nov 29, 2017

Publish this feature please. It's been almost a month.

@felixfbecker
Copy link
Contributor

felixfbecker commented Dec 12, 2017

@jahed we published lastest master as @sourcegraph/chromeless because we could not have used chromeless with our infrastructure otherwise, feel free to use that.

@schickling is there anything that is blocking this from getting released? That fork has been working fine for us for the past weeks

@jahed
Copy link

jahed commented Dec 13, 2017

@felixfbecker no worries, I did the same thing. No point waiting for others when you can do it yourself in the meantime 👍 It turned out chromeless wasn't the solution I needed.

https://www.npmjs.com/package/@jahed/chromeless

@schickling
Copy link
Owner

@felixfbecker apologies we've been buried in work over the last 2 months. Would you be open to join as a maintainer and cut a release?

@felixfbecker
Copy link
Contributor

felixfbecker commented Dec 13, 2017

Sure. Might not be able to make a big maintenance/time commitment though, but may prep a PR to automate the release process to prevent this in the future :)

@felixfbecker
Copy link
Contributor

felixfbecker commented Dec 14, 2017

@jahed @gios released v1.4.0 (and deprecated our fork)

@jahed
Copy link

jahed commented Dec 21, 2017

Cool, I'll delete mine when I get round to it. Think it's safe to close this.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

8 participants