This repository has been archived by the owner on Nov 24, 2018. It is now read-only.
Use port from options instead of this.chromeInstance #162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@joelgriffith please take a look at this. You've implemented the Chrome Launcher. |
|
This would likely also resolve #99 (comment). |
timsuchanek
approved these changes
Aug 4, 2017
|
I know 1.1 just went out, but any chance for a quick release on this? Not having it makes testing pdf generation locally really tough. |
|
@kevinob11 v1.2.0 has been released. |
|
Awesome, thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using a local chrome causes an error where this.chromeInstance is undefined.
this.chromeInstance is not set in connectToChrome and the port for the local chrome might be something else than 9222.
Closes #159