Bug: pgSettings turn value types into strings

[lifeiscontent]

given the following pgSettings:

pgSettings: req => ({
            'user.user_id': req.ctx.session.user_id || ''
          })

I expect the following:

when req.ctx.session.user_id === null to set user.user_id to
expected: "" or null
actual: "null"

when req.ctx.session.user_id === undefined to set user.user_id to
expected: "" or null
actual: "undefined"

[benjie]

Suggestion: strings and numbers should be passed through, null/undefined should be dropped, and everything else should throw an error.

[lifeiscontent]

@benjie if I was to make a PR for this, which branch or repo should I work in?

[benjie]

Master; I'll then merge into v3 and v4

[benjie]

Specifically you want to extract this line and add slightly more logic:

https://github.com/postgraphql/postgraphql/blob/master/src/postgraphql/http/createPostGraphQLHttpRequestHandler.js#L404