fix(koa): don't hang when body is already parsed #780
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously if you had
bodyParser
in your Koa middleware stack before PostGraphile, e.g.then PostGraphile (well, strictly it was
body-parser
itself) would hang whilst processing GraphQL requests because it didn't realise that the request body had already been consumed.I've added some additional middleware which converts the Koa body parsing over to something that looks like Connect body parsing (it has to manipulate the
ctx.req
object to achieve this - sorry!); this should solve this issue.Remember: Koa support is experimental! When raising issues please include a minimal reproduction test case (such as the one above) to help me get to the root of the issue faster.
Fixes #602