Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(http): support mounting on subroutes #894

Merged
merged 5 commits into from
Oct 31, 2018
Merged

feat(http): support mounting on subroutes #894

merged 5 commits into from
Oct 31, 2018

Conversation

benjie
Copy link
Member

@benjie benjie commented Oct 31, 2018

  • Gets rid of /_postgraphile/* (backwards compatible for /_postgraphile/stream in case you hard-coded that (don't!))
  • Stream URL now at /graphql/stream; but don't hard-code that - we set it in the X-GraphQL-Event-Stream header which you should use instead
  • Switches to using originalUrl rather than url when processing the request
  • graphqlRoute and graphiqlRoute are treated as absolute paths - i.e. app.use('/path/to', postgraphile()) will not work, you need to do: app.use('/path/to', postgraphile({graphqlRoute: '/path/to/graphql'}))
  • Even works with Koa/koa-mount
  • Fixes incorrect type for enableQueryBatching

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant