Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Before v4.1.0 release: check GraphQLErrors #896

Closed
benjie opened this issue Oct 31, 2018 · 0 comments
Closed

Before v4.1.0 release: check GraphQLErrors #896

benjie opened this issue Oct 31, 2018 · 0 comments
Labels
✋ release blocker prevents releasing the next version

Comments

@benjie
Copy link
Member

benjie commented Oct 31, 2018

We should be setting things inside of extensions but ONLY if the user is using GraphQL v14 (?)
@benjie benjie added the ✋ release blocker prevents releasing the next version label Nov 13, 2018
@benjie benjie mentioned this issue Nov 23, 2018
Merged
benjie added a commit that referenced this issue Nov 23, 2018
@benjie
fix(graphql): respect GraphQL working draft changes to errors (#923)
442d2b7 
Updates PostGraphile to respect the latest GraphQL spec, using the `exceptions` property on errors:

https://facebook.github.io/graphql/draft/#sec-Errors

Note: we've kept all the old properties for backwards compatibility but these will be removed in version 5 so we strongly recommend you switch to using the new error.extensions.exception object rather than using error directly.

Fixes #896
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
✋ release blocker prevents releasing the next version
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@benjie