Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2024-05] Field a proposal to replace instanceof #125

Open
kitten opened this issue May 29, 2024 · 0 comments
Open

[2024-05] Field a proposal to replace instanceof #125

kitten opened this issue May 29, 2024 · 0 comments

Comments

@kitten
Copy link
Contributor

kitten commented May 29, 2024

Write a proposal to replace instanceof checks (implemented via https://github.com/graphql/graphql-js/blob/main/src/jsutils/instanceOf.ts).

These are currently used for internal schema language class instance checks and an error has been put in place to prevent two instances of the graphql package from cooperating.

This also contains a dev/prod split and check that's causing other issues.

We may want to replace this with a warning (rather than an error) to prevent breaking changes, and replace the general approach on how we identify schema language class instances with something else (what this proposal should define)


Note: Action Item issues are reviewed and closed during Working Group
meetings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant