Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[2020-07-02] Read over GraphQL Custom Scalar PR #509

Closed
benjie opened this issue Oct 1, 2020 · 1 comment
Closed

[2020-07-02] Read over GraphQL Custom Scalar PR #509

benjie opened this issue Oct 1, 2020 · 1 comment
Assignees
@leebyron
Labels
Action item 🎬 Ready for review 🙌 Action Item issues are reviewed and closed during Working Group meetings.

Comments

@benjie
Copy link
Member

benjie commented Oct 1, 2020 •
edited
Loading

ACTION - Lee - read over this and make sure we're not missing anything, and perform the merge.
Lee: it should be clear that you can have scalars in your own domain that are only used in your domain.
Ivan: we should allow vendor URLs. It reduces our workload if people can use vendor-specific things - they'd be less pushy about pushing their scalars to be standard.
ACTION - Lee - make minor changes as a last patch before merging

Custom scalar PR: graphql/graphql-spec#649

Note: Action Item issues are reviewed and closed during Working Group
meetings.
@benjie
Copy link
Member Author

benjie commented May 14, 2021

This was not only read over but also merged 👍

@benjie benjie added the Ready for review 🙌 Action Item issues are reviewed and closed during Working Group meetings. label May 14, 2021
@leebyron leebyron closed this as completed Jun 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@leebyron leebyron

Labels
Action item 🎬 Ready for review 🙌 Action Item issues are reviewed and closed during Working Group meetings.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@leebyron @benjie