feat: add ability to specify an array in expectedResponseContentType #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bezany
reviewed
Mar 26, 2024
lib/components/rest.ts
Outdated
| }); | ||
| ctx.end(); | ||
| if (actualResponseContentType && expectedResponseContentType) { | ||
| let invalidResponseContentType; |
There was a problem hiding this comment.
Maybe rename it to isInvalidResponseContentType?
bezany
approved these changes
Mar 26, 2024
SeqviriouM
deleted the
seqvirioum/expected-response-content-type-as-array
branch
resure
reviewed
Mar 26, 2024
| }); | ||
| ctx.end(); | ||
| if (actualResponseContentType && expectedResponseContentType) { | ||
| let isInvalidResponseContentType; |
There was a problem hiding this comment.
It might have been look a little simpler if you've checked for valid response content type instead of invalid (since not- checks are harder to read than positive ones).
i.e.
isValidResponseContentType = false
isValidResponseContentType = expectedResponseContentType.includes(String(actualResponseContentType));
isValidResponseContentType = expectedResponseContentType === actualResponseContentType
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the ability to specify an array in
expectedResponseContentTypeoption