feat: add ability to customize debugHeaders via option proxyDebugHeaders #52
Conversation
lib/components/grpc.ts
Outdated
| } else if (Array.isArray(options.proxyDebugHeaders)) { | ||
| for (const headerName of options.proxyDebugHeaders) { | ||
| if (headers[headerName] !== undefined) { | ||
| debugHeaders[`x-${headerName}`] = headers[headerName]; |
There was a problem hiding this comment.
I think it's not best idea to add x- prefix in itself because it can lead to headers like x-x-request-id, x-x-forwarded-for and others, which is not entirely clear. I suggest to use at least x-header- prefix to separate them from default debug headers. But generally it's not a big deal
There was a problem hiding this comment.
I've decided to use x-gateway prefix
lib/components/grpc.ts
Outdated
| if (headers['uber-trace-id']) { | ||
| debugHeaders['x-uber-trace-id'] = headers['uber-trace-id']; | ||
| } |
There was a problem hiding this comment.
I believe we don't need to do this because this is specific header (uber-trace-id is Jaeger naming as I know) which is used in the @gravity-ui/nodekit only and not related to @gravity-ui/gateway itself. @gravity-ui/gateway can be used without @gravity-ui/nodekit
There was a problem hiding this comment.
Ok, I agree with you
Add ability to customize debugHeaders via option
proxyDebugHeaders.Close #50