Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Table): table settings component added #51

Merged
merged 46 commits into from
Sep 26, 2024

Conversation

TaPo4eK111291
Copy link
Contributor

No description provided.

@gravity-ui-bot
Copy link
Contributor

Preview is ready.

Copy link
Collaborator

@beliarh beliarh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Is it possible to prevent some columns from hiding? (by disabling checkbox for example)
  2. Parent column's checkbox is not clickable for some reason
  3. What about supporting the column pinning feature?

src/utils/addComponentKeysets.ts Outdated Show resolved Hide resolved
src/components/TableSettingsColumn/TableSettingsColumn.tsx Outdated Show resolved Hide resolved
src/components/TableSettings/TableSettings.tsx Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
src/components/TableSettings/TableSettings.tsx Outdated Show resolved Hide resolved
src/components/TableSettingsColumn/TableSettingsColumn.tsx Outdated Show resolved Hide resolved
@TaPo4eK111291
Copy link
Contributor Author

  • Is it possible to prevent some columns from hiding? (by disabling checkbox for example)
  • Parent column's checkbox is not clickable for some reason
  • What about supporting the column pinning feature?
  1. Added reaction to enableHiding prop in columns config. Now u can set it to false, for prevent toggling.
  2. Fixed.
  3. Right now we don't have mockups for pinning and disabling other behaviours, we'll add them separately.

@Raubzeug
Copy link

Name of group name should be bold.
Screenshot 2024-09-24 at 11 36 58

@Raubzeug
Copy link

Drag handler is not centered:
Screenshot 2024-09-24 at 11 38 09

@Raubzeug
Copy link

Column with settings handler should always be visible (pinned on the end of the flow (depends on rtl or ltr)).

src/components/TableSettings/TableSettings.tsx Outdated Show resolved Hide resolved
src/components/TableSettings/TableSettings.tsx Outdated Show resolved Hide resolved
src/components/TableSettings/TableSettings.scss Outdated Show resolved Hide resolved
src/components/TableSettings/TableSettings.utils.ts Outdated Show resolved Hide resolved
src/components/TableSettingsColumn/TableSettingsColumn.tsx Outdated Show resolved Hide resolved
src/components/TableSettings/TableSettings.tsx Outdated Show resolved Hide resolved
src/constants/settingsColumn.tsx Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
src/utils/configure.ts Outdated Show resolved Hide resolved
@TaPo4eK111291
Copy link
Contributor Author

Name of group name should be bold. Screenshot 2024-09-24 at 11 36 58

Fixed

Raubzeug
Raubzeug previously approved these changes Sep 24, 2024
@beliarh beliarh merged commit 8936fe1 into main Sep 26, 2024
3 checks passed
@beliarh beliarh deleted the feat/column-settings-component branch September 26, 2024 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants