generated from gravity-ui/package-example
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(Table): table settings component added #51
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Preview is ready. |
beliarh
requested changes
Sep 22, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Is it possible to prevent some columns from hiding? (by disabling checkbox for example)
- Parent column's checkbox is not clickable for some reason
- What about supporting the column pinning feature?
src/components/TableSettings/__stories__/stories/TableSettingsColumnStory.tsx
Outdated
Show resolved
Hide resolved
src/components/TableSettings/__stories__/stories/TableSettingsColumnStory.tsx
Outdated
Show resolved
Hide resolved
|
Column with settings handler should always be visible (pinned on the end of the flow (depends on rtl or ltr)). |
Raubzeug
requested changes
Sep 24, 2024
TaPo4eK111291
force-pushed
the
feat/column-settings-component
branch
from
September 24, 2024 14:28
d8c0a20
to
2fd151e
Compare
Raubzeug
previously approved these changes
Sep 24, 2024
beliarh
requested changes
Sep 26, 2024
src/components/TableSettingsColumn/TableSettingsColumn.utils.ts
Outdated
Show resolved
Hide resolved
beliarh
approved these changes
Sep 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.