From 9a4bd597cc0db62f905d6972eb317faffd8cb672 Mon Sep 17 00:00:00 2001
From: Mikhail Golbakh <golbah@yandex.ru>
Date: Fri, 22 Sep 2023 12:20:41 +0300
Subject: [PATCH] feat(UserAvatar): add fallbackImgUrl prop (#1025)

---
 src/components/UserAvatar/README.md           | 17 ++++----
 src/components/UserAvatar/UserAvatar.tsx      | 43 +++++++++++++------
 .../__stories__/UserAvatar.stories.tsx        | 16 +++++--
 3 files changed, 51 insertions(+), 25 deletions(-)

diff --git a/src/components/UserAvatar/README.md b/src/components/UserAvatar/README.md
index 240f6e074..8b79b403b 100644
--- a/src/components/UserAvatar/README.md
+++ b/src/components/UserAvatar/README.md
@@ -4,11 +4,12 @@ Component for displaying user avatar.
 
 ### PropTypes
 
-| Name      | Type             | Required | Default | Description                                                |
-| :-------- | :--------------- | :------- | :------ | :--------------------------------------------------------- |
-| imgUrl    | `string`         |          |         | Link to image                                              |
-| size      | `UserAvatarSize` |          | 'm'     | Component size. Possible values: `xs`, `s`, `m`, `l`, `xl` |
-| srcSet    | `string`         |          |         | `srcSet` attribute of the image                            |
-| sizes     | `string`         |          |         | `sizes` attribute of the image                             |
-| title     | `string`         |          |         | Tooltip text on hover                                      |
-| className | `string`         |          |         | Class name                                                 |
+| Name           | Type             | Required | Default | Description                                                |
+| :------------- | :--------------- | :------- | :------ | :--------------------------------------------------------- |
+| imgUrl         | `string`         |          |         | Link to image                                              |
+| fallbackImgUrl | `string`         |          |         | Link to fallback image                                     |
+| size           | `UserAvatarSize` |          | 'm'     | Component size. Possible values: `xs`, `s`, `m`, `l`, `xl` |
+| srcSet         | `string`         |          |         | `srcSet` attribute of the image                            |
+| sizes          | `string`         |          |         | `sizes` attribute of the image                             |
+| title          | `string`         |          |         | Tooltip text on hover                                      |
+| className      | `string`         |          |         | Class name                                                 |
diff --git a/src/components/UserAvatar/UserAvatar.tsx b/src/components/UserAvatar/UserAvatar.tsx
index f55d62b39..2e88d45e4 100644
--- a/src/components/UserAvatar/UserAvatar.tsx
+++ b/src/components/UserAvatar/UserAvatar.tsx
@@ -9,6 +9,7 @@ import './UserAvatar.scss';
 
 export interface UserAvatarProps {
     imgUrl?: string;
+    fallbackImgUrl?: string;
     size?: UserAvatarSize;
     srcSet?: string;
     sizes?: string;
@@ -21,20 +22,34 @@ export interface UserAvatarProps {
 const b = block('user-avatar');
 
 export const UserAvatar = React.forwardRef<HTMLDivElement, UserAvatarProps>(
-    ({imgUrl, size = 'm', srcSet, sizes, title, className, onClick}, ref) => (
-        // eslint-disable-next-line jsx-a11y/click-events-have-key-events, jsx-a11y/no-static-element-interactions
-        <div title={title} className={b({size}, className)} onClick={onClick} ref={ref}>
-            <img
-                className={b('figure')}
-                width={SIZES[size]}
-                height={SIZES[size]}
-                src={imgUrl}
-                srcSet={srcSet}
-                sizes={sizes}
-                alt={''}
-            />
-        </div>
-    ),
+    ({imgUrl, fallbackImgUrl, size = 'm', srcSet, sizes, title, className, onClick}, ref) => {
+        const [isErrored, setIsErrored] = React.useState(false);
+
+        const handleError = React.useCallback(() => {
+            setIsErrored(true);
+        }, []);
+
+        // Reset error if `imgUrl` was changed to check it again
+        React.useEffect(() => {
+            setIsErrored(false);
+        }, [imgUrl]);
+
+        return (
+            // eslint-disable-next-line jsx-a11y/click-events-have-key-events, jsx-a11y/no-static-element-interactions
+            <div className={b({size}, className)} title={title} onClick={onClick} ref={ref}>
+                <img
+                    className={b('figure')}
+                    width={SIZES[size]}
+                    height={SIZES[size]}
+                    src={fallbackImgUrl && isErrored ? fallbackImgUrl : imgUrl}
+                    srcSet={srcSet}
+                    sizes={sizes}
+                    alt=""
+                    onError={handleError}
+                />
+            </div>
+        );
+    },
 );
 
 UserAvatar.displayName = 'UserAvatar';
diff --git a/src/components/UserAvatar/__stories__/UserAvatar.stories.tsx b/src/components/UserAvatar/__stories__/UserAvatar.stories.tsx
index 8b36bad83..ca6a8840e 100644
--- a/src/components/UserAvatar/__stories__/UserAvatar.stories.tsx
+++ b/src/components/UserAvatar/__stories__/UserAvatar.stories.tsx
@@ -2,7 +2,7 @@ import React from 'react';
 
 import {faker} from '@faker-js/faker/locale/en';
 import {useArgs} from '@storybook/client-api';
-import type {ComponentStory, Meta, StoryFn} from '@storybook/react';
+import type {Meta, StoryFn} from '@storybook/react';
 
 import {UserAvatar} from '../UserAvatar';
 import type {UserAvatarProps} from '../UserAvatar';
@@ -42,7 +42,7 @@ const randomAvatars = faker.helpers
         }),
         {},
     );
-export const WithSrcSet: ComponentStory<typeof UserAvatar> = (args) => {
+export const WithSrcSet: StoryFn<UserAvatarProps> = (args) => {
     const [, setArgs] = useArgs();
 
     React.useEffect(() => {
@@ -54,6 +54,16 @@ export const WithSrcSet: ComponentStory<typeof UserAvatar> = (args) => {
     return <UserAvatar {...args} />;
 };
 WithSrcSet.args = {
-    imgUrl: faker.image.cats(),
+    imgUrl: faker.image.urlLoremFlickr({category: 'cats'}),
+    size: 'xl',
+};
+
+export const WithFallback: StoryFn<UserAvatarProps> = (args) => {
+    return <UserAvatar {...args} />;
+};
+WithFallback.args = {
+    // Invalid image link
+    imgUrl: imgUrl + '1',
+    fallbackImgUrl: imgUrl,
     size: 'xl',
 };