feat!: support RTL direction #1111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amje
requested review from
resure,
ogonkov,
korvin89,
sofiushko,
zamkovskaya,
SeqviriouM,
mournfulCoroner,
DaffPunks,
Lunory,
kseniya57,
jhoncool,
NikitaCG,
goshander,
axtk and
ValeraS
as code owners
|
Preview is ready. |
NikitaCG
approved these changes
Nov 9, 2023
44 tasks
zamkovskaya
approved these changes
Nov 9, 2023
korvin89
approved these changes
Nov 10, 2023
ogonkov
reviewed
Nov 11, 2023
| "rules": { | ||
| "csstools/use-logical": ["always", {"except": ["float", "width", "min-width", "max-width", "height", "min-height", "max-height"]}], |
There was a problem hiding this comment.
why this props are exception?
There was a problem hiding this comment.
float has weak browsers support, widht and height needed for different writing-mode which we are not planning to support now
There was a problem hiding this comment.
that would be better to add new function for dir toggle instead of putting new logic here
mournfulCoroner
approved these changes
Nov 13, 2023
ogonkov
approved these changes
Nov 13, 2023
amje
added a commit
that referenced
this pull request
Dec 6, 2023
amje
added a commit
that referenced
this pull request
Feb 1, 2024
amje
added a commit
that referenced
this pull request
Feb 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.