feat(Disclosure): use logical properties #1140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview is ready. |
amje
changed the title
amje
changed the title
amje
requested changes
Nov 17, 2023
amje
requested changes
Nov 20, 2023
src/components/Disclosure/README.md
Outdated
| @@ -11,7 +11,7 @@ Disclosure component that shows and hides enclosed content. | |||
| | disabled | `Boolean` | | `false` | Disabled state | | |||
| | defaultExpanded | `Boolean` | | `false` | Default opening state | | |||
| | expanded | `Boolean` | | | Controlled opening state | | |||
| | arrowPosition | `left` `right` | | `left` | Control position | | |||
| | arrowPosition | `left` `right` `start` `end` | | `start` | Control position | | |||
There was a problem hiding this comment.
We suppose left and right are being deprecated, so they don’t need to be documented
| @@ -38,11 +38,19 @@ export function DefaultDisclosureSummary({ | |||
| disabled, | |||
| }: DisclosureSummaryRenderFunctionProps) { | |||
| const {size, summary, arrowPosition} = useDisclosureAttributes(); | |||
| let sideMod = arrowPosition; | |||
amje
requested changes
Nov 20, 2023
| @@ -11,7 +11,7 @@ import {b} from './cn'; | |||
| import './Disclosure.scss'; | |||
|
|
|||
| export type DisclosureSize = 'm' | 'l' | 'xl'; | |||
| export type DisclosureArrowPosition = 'left' | 'right' | 'start' | 'end'; | |||
There was a problem hiding this comment.
It would break typings for those who passes this type to the props. Let's keep them here. I will add warning later, for all such types
amje
approved these changes
Nov 20, 2023
44 tasks
ogonkov
pushed a commit
that referenced
this pull request
Nov 27, 2023
ogonkov
pushed a commit
that referenced
this pull request
Nov 27, 2023
amje
pushed a commit
that referenced
this pull request
Dec 6, 2023
amje
pushed a commit
that referenced
this pull request
Feb 1, 2024
amje
pushed a commit
that referenced
this pull request
Feb 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.