feat: add useControlledState hook #1276
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Playwright Test Component is ready. |
korvin89
approved these changes
Jan 26, 2024
amje
requested changes
Jan 26, 2024
|
|
||
| import {useControlledState} from './useControlledState'; | ||
|
|
||
| describe('useControlledState tests', function () { |
There was a problem hiding this comment.
"tests" word is redundant I guess
| const wasControlled = isControlledRef.current; | ||
| if (wasControlled !== isControlled) { | ||
| console.warn( | ||
| `WARN: A component changed from ${ |
There was a problem hiding this comment.
Let's use console.error for better visibility. Also let's use the following format: [useControlledState] <message>
|
Preview is ready. |
ValeraS
force-pushed
the
feat/useControlledState
branch
from
18c9c90
to
78ab8ad
Compare
amje
approved these changes
Jan 26, 2024
amje
pushed a commit
that referenced
this pull request
Feb 1, 2024
amje
pushed a commit
that referenced
this pull request
Feb 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.