Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Can't change dialog width #1509

Closed
saxumcordis opened this issue Apr 12, 2024 · 2 comments · Fixed by #1510
Closed

Can't change dialog width #1509

saxumcordis opened this issue Apr 12, 2024 · 2 comments · Fixed by #1510
Labels
bug Something isn't working component: Dialog

Comments

@saxumcordis
Copy link
Contributor

it is necessary to reverse the order of variables to give opportunity to change dialog width

https://github.com/gravity-ui/uikit/blob/31c22e8418f67cb2df3354350f19e44471918aa4/src/components/Dialog/Dialog.scss#L12C5-L12C51
@saxumcordis saxumcordis added bug Something isn't working component: Dialog labels Apr 12, 2024
@saxumcordis
Copy link
Contributor Author

#1510

@saxumcordis saxumcordis linked a pull request Apr 12, 2024 that will close this issue
fix(Dialog): correct width's vars order #1510
Merged
@saxumcordis
Copy link
Contributor Author

its ok
I can set size=undefined and then fallback will work, ok

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working component: Dialog
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(Dialog): correct width's vars order gravity-ui/uikit
1 participant
@saxumcordis